[6.2] Use the Windows SDK arguments over the environment #10913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
compnerd
approved these changes
Jun 27, 2025
DougGregor
approved these changes
Jun 27, 2025
ravikandhadai
approved these changes
Jun 27, 2025
|
@ravikandhadai Could you land this for me please? I do not have the rights. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the toolchain usable in a VS Dev Environment when any of the Windows SDK / MSVC build tools command line arguments are specified.
This only affects the Windows build when run in a VS Dev Environment.
N/A
Upstream LLVM PR: Use the Windows SDK arguments over the environment llvm/llvm-project#144805
Stable branch PR: 🍒 Use the Windows SDK arguments over the environment (llvm#144805) #10895
Limited, this has been tested on main. CI should notify of breakages.
Tested locally with a project using
-win-sdk-version+ new LLVM tests.@compnerd